Adjust drive definition from unix time range to openpilot route #486
Conversation
|
Merged the new demo account. Should help with testing this. |
|
Welcome to connect! Make sure to:
deployed preview: https://486.connect-d5y.pages.dev |
|
0x7B5
changed the title
|
Ready for review? Want to post the preview link in Discord for people to stress test? |
|
Yes, will do |
| return null; | ||
| } | ||
|
|
||
| return Math.floor(offset / (60*1000)); |
There was a problem hiding this comment.
this isn't quite correct: log rotation bugs, missing segments, etc. however i think it's good enough for now
There was a problem hiding this comment.
It isn't currently listed in the docs for derived data, but we recently started generating a file that gives you the first and last frame time of each segment relative to the start of the route named frame_times.json.
The file is similar to the GPS data points, but at the route level, for example:
https://chffrprivate.azureedge.net/chffrprivate3/v2/cb38263377b873ee/78392b99580c5920227cc5b43dff8a70_2017-06-12--18-51-47/frame_times.json
|
Resolved issues |
There was a problem hiding this comment.
For routes without the correct time (too short, no internet, something wrong), can you sort by upload time? @adeebshihadeh will add new outputs to the API shortly for create_time (upload time). Right now it uses device time
|
I clicked on "Last week" to filter, and it started opening a few routes randomly, with no change to the URL (still only shows dongle). |
|
Also, when loading a route from URL on a device with >hundreds of routes, it seems to wait for the routes_segments query to complete which is very slow (fixable by reducing that and doing infinite scrolling I believe). On routes without start_time, it also never loaded, but that may be okay as the routes I tested also only had one qlog and no qcameras |
Are you referring to when you go to an old url like "https://connect.comma.ai/1d3dc3e03047b0c7/1716477480803/1716478866821" and it redirects? Or route url loading in general? |
|
|
Merged anyway to start getting feedback |
Just fixed |
| if (pathZoom !== state.zoom) { | ||
| dispatch(pushTimelineRange(pathZoom?.start, pathZoom?.end, false)); |
There was a problem hiding this comment.
@0x7B5 this used to reset the timeline zoom points when you pressed back in the browser, but below I don't think ever executes anymore, or at least not in this case.
fixes #473